Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-1090) Verify the changelog top most version matches the metadata version #1088

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

carabasdaniel
Copy link
Contributor

@carabasdaniel carabasdaniel commented Jun 10, 2021

Closes #917 #1090

@carabasdaniel carabasdaniel marked this pull request as ready for review June 11, 2021 10:11
@carabasdaniel carabasdaniel requested a review from a team as a code owner June 11, 2021 10:11
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are fixing two separate bugs in one PR, can you please split the changes into two commits and add the appropriate detail to the commit message? This helps with our release process

If you don't have time, I can do that instead

@jpogran jpogran changed the title Verify the changelog top most version matches the metadata version (GH-1090) Verify the changelog top most version matches the metadata version Jun 11, 2021
@carabasdaniel
Copy link
Contributor Author

Hi @jpogran,
Split the work into the two relevant commits and rebased on top of latest main.

Daniel Carabas added 2 commits June 14, 2021 11:25
Sets the forge-token argument in release cli command as not required so that new module interviews will not fail.
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #1088 (56008f5) into main (a8671e0) will decrease coverage by 0.00%.
The diff coverage is 91.66%.

❗ Current head 56008f5 differs from pull request most recent head 2e70d47. Consider uploading reports for the commit 2e70d47 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1088      +/-   ##
==========================================
- Coverage   91.25%   91.25%   -0.01%     
==========================================
  Files         137      137              
  Lines        5559     5569      +10     
==========================================
+ Hits         5073     5082       +9     
- Misses        486      487       +1     
Impacted Files Coverage Δ
lib/pdk/cli/exec/command.rb 88.88% <ø> (-0.09%) ⬇️
lib/pdk/module/release.rb 97.67% <66.66%> (-0.74%) ⬇️
lib/pdk/cli/release.rb 50.00% <100.00%> (ø)
lib/pdk/util/changelog_generator.rb 96.49% <100.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 986daec...2e70d47. Read the comment docs.

Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed up the commits, will merge when green

@jpogran jpogran merged commit 70b58a9 into puppetlabs:main Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify the changelog top most version matches the metadata version pdk release fails to build without token
3 participants