Commits on Jul 7, 2021

1. (GH-1113) Fix incorrect opt type for forge-token …

   Prior to this fix, the `forge-token` option defined in the PDK::CLI's
   `release` subcommand did not have the `argument:` attribute set.
   This meant that the underlying Cri lib treated it as a boolean option
   and the forge token value was set to `true` and passed to the
   `PDK::Module::Release` object.
   
   This fix sets the `argument:` attribute with the value `:optional`,
   which allows it to be optional but treated as an arg that needs the
   value extracted after `=`

   sanfrancrisko committed Jul 7, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 10bf701
   • Browse repository at this point

   Copy the full SHA

   10bf701 View commit details

   Browse the repository at this point in the history

2. (GH-917) Fix incorrect 'Missing forge-token' error throwing …

   Prior to this commit, when running `pdk release` and stepping
   through the interview questions, even if you selected `N` to the
   publish forge question, a warning would still display stating:
   
   ```sh
   pdk (ERROR): Missing forge-token option
   ```
   
   This commit sets the `:skip_publish` option to true in `opts` that
   gets passed to the `PDK::Module::Release` object on init. This will
   ensure that the `skip_publish?` call returns `true` and the
   Forge token check is not performed.
   
   This was incorrectly asserted as resolved in `2.1.1` of the PDK.

   sanfrancrisko committed Jul 7, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 6c2c4e9
   • Browse repository at this point

   Copy the full SHA

   6c2c4e9 View commit details

   Browse the repository at this point in the history