Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CONT-370) Remove i18n support #1211

Merged
merged 1 commit into from
Feb 16, 2023
Merged

(CONT-370) Remove i18n support #1211

merged 1 commit into from
Feb 16, 2023

Conversation

chelnak
Copy link
Contributor

@chelnak chelnak commented Feb 15, 2023

This change removes i18n support from PDK as it is no longer required.

Additionally we have also seen a small performance improvement as a result of this work.

@chelnak chelnak self-assigned this Feb 15, 2023
@chelnak chelnak requested a review from a team as a code owner February 15, 2023 16:07
@chelnak chelnak force-pushed the CONT-320-remove_i18n branch 3 times, most recently from c67301f to 684b2d7 Compare February 15, 2023 19:22
lib/pdk/cli.rb Outdated Show resolved Hide resolved
lib/pdk/cli.rb Outdated Show resolved Hide resolved
This commit removes i18n support from PDK as it is no longer required.

Additionally we have also seen a small performance improvement as a
result of this work.
@chelnak chelnak mentioned this pull request Feb 16, 2023
Copy link
Contributor

@GSPatton GSPatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me

@GSPatton GSPatton merged commit 50544e9 into main Feb 16, 2023
@GSPatton GSPatton deleted the CONT-320-remove_i18n branch February 16, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants