Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CONT-755) Ruby 3 / Puppet 8 support #1230

Merged
merged 121 commits into from
Apr 24, 2023
Merged

Conversation

chelnak
Copy link
Contributor

@chelnak chelnak commented Mar 15, 2023

This PR contains a number of changes that ensure PDK is compatible with Ruby 3 / Puppet 8.

@chelnak chelnak self-assigned this Mar 15, 2023
@chelnak chelnak force-pushed the CONT-755-rubocop_updates branch 2 times, most recently from 902cece to a59527e Compare March 16, 2023 15:42
@chelnak chelnak force-pushed the CONT-755-rubocop_updates branch 8 times, most recently from 6455211 to a4a2bc5 Compare March 31, 2023 16:11
@chelnak chelnak force-pushed the CONT-755-rubocop_updates branch 8 times, most recently from 8aaa5b8 to f240f5d Compare April 20, 2023 16:10
@chelnak chelnak force-pushed the CONT-755-rubocop_updates branch 2 times, most recently from 478d58a to 4bebdbb Compare April 20, 2023 16:30
@chelnak chelnak marked this pull request as ready for review April 20, 2023 16:31
@chelnak chelnak requested a review from a team as a code owner April 20, 2023 16:31
@chelnak chelnak changed the title (CONT-755) Rubocop updates (CONT-755) Ruby 3 / Puppet 8 support Apr 20, 2023
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment but otherwise LGTM

Rakefile Outdated Show resolved Hide resolved
The CI workflows set this variable for use with other tooling tests.

This commit removes it from the current environment when pdk tests are
being set up.
.gitignore Outdated Show resolved Hide resolved
lib/pdk/config/analytics_schema.json Outdated Show resolved Hide resolved
@david22swan david22swan merged commit eb56c5e into main Apr 24, 2023
@david22swan david22swan deleted the CONT-755-rubocop_updates branch April 24, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants