(CONT-935) Fix issues with PDK package and tests #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelnak
force-pushed
the
CONT-935-pdk_fixes
branch
2 times, most recently
from
6584844
to
ce97fae
Compare
jordanbreen28
approved these changes
May 25, 2023
chelnak
force-pushed
the
CONT-935-pdk_fixes
branch
12 times, most recently
from
fe53b86
to
ffe850a
Compare
Ramesh7
approved these changes
May 26, 2023
chelnak
force-pushed
the
CONT-935-pdk_fixes
branch
2 times, most recently
from
4a49493
to
23a16a3
Compare
Previously, the original initialize method was updated to use super given tha the same variable declarations were in the parent class. For some strange reason, this appeared to cause some issues so this commit reverts that change.
At this point, facter should be already loaded so we don't need it here. When the require statement is present, the user will see many "ALREADY INITIALIZED CONSTANT" warnings.
Prior to this commit, there were still references to travis in the tests. This was causing failures when using the latest pdk-template versions as trave has now been removed. This change removes references to travis.
Prior to this change, the example count in a few tests was incorrect. This was causing the tests to fail. This change corrects the example count to help the tests pass.
Prior to this change the tests were unable to recognise when Puppet 8 was a requirement. This change ensures that when Ruby 3 is being used, Puppet 8 is also used.
chelnak
force-pushed
the
CONT-935-pdk_fixes
branch
from
23a16a3
to
0602330
Compare
chelnak
changed the title
Ramesh7
approved these changes
May 26, 2023
GSPatton
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two small fixes for issues discovered while preparing the package for PDK 3.0.
Additionally, there are also some fixes for the unit and acceptance tests to allow this PR to be green.