(maint) Remove nil values from metadata before generating JSON #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not waiting to merge this one due to the US long weekend and this fixes the broken builds on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new release of metadata-json-lint was pushed out a couple of days ago that included voxpupuli/metadata-json-lint#68 which causes the data types for the metadata values to get validated. This is causing our acceptance tests to fail because we include
nilvalues (translated tonullin JSON) in our generated metadata.json.This change compacts the metadata hash to remove those keys with
nilvalues (optional metadata elements like issues_url) before generating the JSON structure.