(CAT-1796) Fix missing locale gem #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following some investigation, it was noted that the pdk gem could not work correctly when analytics were enabled. This was due to the fact that the locale gem was missing for its correct operation. This commit adds the locale gem to the pdk.gemspec to solve the current issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1337 +/- ##
=======================================
Coverage 88.51% 88.51%
=======================================
Files 133 133
Lines 5666 5666
=======================================
Hits 5015 5015
Misses 651 651 ☔ View full report in Codecov by Sentry. |
david22swan
approved these changes
Apr 10, 2024
|
This version of the locale gem (currently 2.1.4) triggers a license violation in CD4PE's Mend scans. There isn't a "fixed" version to go to, so we may need to get an exception or something. Just wanted to note that this might cause wider issues. I think we had perhaps heard that there was talk of removing the analytics code that relies on this, since those are disabled by default and aren't really used? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following some investigation, it was noted that
the pdk gem could not work correctly when analytics were enabled. This was due to the fact that the
locale gem was missing for its correct operation.
This commit adds the locale gem to the pdk.gemspec to solve the current issue.
Checklist