Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1643) Update childprocess and remove patch #1356

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented May 15, 2024

Previously a specific patch was required in order to have the code work as intended, however a patch has since been moved into the gem and so we can remove our patch and update the dependency.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@david22swan david22swan marked this pull request as ready for review May 15, 2024 12:50
@david22swan david22swan requested a review from a team as a code owner May 15, 2024 12:50
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (78e8249) to head (224d9fe).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1356      +/-   ##
==========================================
+ Coverage   87.81%   88.24%   +0.43%     
==========================================
  Files         129      128       -1     
  Lines        5489     5435      -54     
==========================================
- Hits         4820     4796      -24     
+ Misses        669      639      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david22swan
Copy link
Member Author

Just waiting on pipeline fix to merge

Previously a specific patch was required in order to  have the code work as intended, however a patch has since been moved into the gem and so we can remove our patch and update the dependency.
@jordanbreen28 jordanbreen28 merged commit f5a5d70 into main May 22, 2024
10 of 11 checks passed
@jordanbreen28 jordanbreen28 deleted the CAT-1643 branch May 22, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants