(CAT-1896) - Use puppet-modulebuilder for PDK build
#1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
force-pushed
the
cat-1896-use_puppet-modulebuilder
branch
3 times, most recently
from
cee086d
to
a758f5b
Compare
jordanbreen28
changed the title
PDK buildPDK build & Add module_dir option to pdk build
jordanbreen28
changed the title
PDK build & Add module_dir option to pdk buildPDK build & Add module-dir option to pdk build
jordanbreen28
force-pushed
the
cat-1896-use_puppet-modulebuilder
branch
9 times, most recently
from
7d6523a
to
3eb999b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1374 +/- ##
==========================================
+ Coverage 88.24% 88.54% +0.30%
==========================================
Files 128 127 -1
Lines 5435 5334 -101
==========================================
- Hits 4796 4723 -73
+ Misses 639 611 -28 ☔ View full report in Codecov by Sentry. |
jordanbreen28
force-pushed
the
cat-1896-use_puppet-modulebuilder
branch
2 times, most recently
from
37c1db4
to
26c6f32
Compare
jordanbreen28
changed the title
PDK build & Add module-dir option to pdk buildPDK build & Add module-dir option to pdk build
jordanbreen28
force-pushed
the
cat-1896-use_puppet-modulebuilder
branch
from
26c6f32
to
e1a02df
Compare
jordanbreen28
changed the title
PDK build & Add module-dir option to pdk buildPDK build
jordanbreen28
force-pushed
the
cat-1896-use_puppet-modulebuilder
branch
6 times, most recently
from
41f707f
to
efac6dc
Compare
jordanbreen28
force-pushed
the
cat-1896-use_puppet-modulebuilder
branch
from
efac6dc
to
4627f32
Compare
This commit updates the pdk to use the module builder gem for its build functionality. The PDK build code had largely duplicated this, therefore we were maintaining two codebases with very similiar purpose.
jordanbreen28
force-pushed
the
cat-1896-use_puppet-modulebuilder
branch
from
4627f32
to
f01112c
Compare
gavindidrichsen
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the pdk to use the module builder gem for its build functionality. The PDK build code had largely duplicated this, therefore we were maintaining two codebases with very similiar purpose.
The use of the modulebuilder gem means we now only have to maintain the build code in one place.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist