Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-2026) Update how pdk test unit --list detects an error #1388

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented Aug 28, 2024

A recent change has caused the information returned to be in a slightly different format.
Message returned may be different, and include additional details.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@david22swan david22swan requested a review from a team as a code owner August 28, 2024 11:11
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.50%. Comparing base (9041f64) to head (e1c7350).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lib/pdk/tests/unit.rb 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1388      +/-   ##
==========================================
- Coverage   88.52%   88.50%   -0.02%     
==========================================
  Files         127      127              
  Lines        5334     5334              
==========================================
- Hits         4722     4721       -1     
- Misses        612      613       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david22swan david22swan force-pushed the CAT-2026 branch 5 times, most recently from cfff65a to 6e1b471 Compare August 28, 2024 16:48
A recent change has caused the information returned to be in a slightly different format.
Message returned may be different, and include additional details.
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit ace2f29 into main Aug 29, 2024
8 of 11 checks passed
@LukasAud LukasAud deleted the CAT-2026 branch August 29, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants