(SDK-306) Use vendored development gems in package install #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotje
commented
Jul 11, 2017
| # TODO: we should probably more carefully manage PATH and maybe other things too | ||
| @process.environment['GEM_HOME'] = File.join(PDK::Util.cachedir, 'bundler', 'ruby', RbConfig::CONFIG['ruby_version']) | ||
| @process.environment['GEM_PATH'] = pdk_gem_path |
There was a problem hiding this comment.
Hmmm, I might actually need to put this back for gem installs now that I'm doing --path again...
There was a problem hiding this comment.
Updated this and have a companion PR in the vanagon repo here: puppetlabs/pdk-vanagon#24
scotje
force-pushed
the
306_use_vendored_template_gems
branch
from
d5b4ca6
to
4c81d03
Compare
scotje
force-pushed
the
306_use_vendored_template_gems
branch
from
db671a9
to
40f2f6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.