(SDK-317) Ensure parent of 'pdk new module' is writable before generation #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
reviewed
Jul 19, 2017
| let(:target_parent_writeable) { false } | ||
|
|
||
| it 'raises a FatalError' do | ||
| expect { |
There was a problem hiding this comment.
Do you also need to expect that it doesn't start the interview here first?
There was a problem hiding this comment.
The ways I tried doing this as a unit test were all pretty clunky a likely to just silently continue passing if the underlying code was refactored. I'm inclined to just merge as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does an initial check before starting the interview, so that we don't waste the user's time. Also rescues
Errno::EACCESfromFileUtils.mvin the event that the permissions change between the pre-run check and the module generation.