(SDK-321) add pdk validate help
#183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
force-pushed
the
sdk-321-pdk-validate-help
branch
from
75b9aad
to
2b46724
Compare
| @@ -17,6 +17,11 @@ module PDK::CLI | |||
| flag :a, 'auto-correct', _('automatically correct problems (where possible)') | |||
|
|
|||
| run do |opts, args, _cmd| | |||
| if args == ['help'] | |||
There was a problem hiding this comment.
Is there a Cri way to do this? For other commands (test, new) it looks like we get the help subcommand for free. But it looks like 'validate' is different since on it's own (just 'pdk validate') it is a valid command
There was a problem hiding this comment.
Adding @validate_cmd.add_command Cri::Command.new_basic_help works
There was a problem hiding this comment.
validate is "special" because the choice of validator conflicts with CRI's parsing of validate help. Try it, acceptance tests will fail.
james-stocks
approved these changes
Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.