Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(MAINT) Add --strict-dependencies to metadata-json-lint invocation #213

Merged
merged 1 commit into from
Aug 1, 2017
Merged

(MAINT) Add --strict-dependencies to metadata-json-lint invocation #213

merged 1 commit into from
Aug 1, 2017

Conversation

scotje
Copy link
Contributor

@scotje scotje commented Aug 1, 2017

metadata-json-lint 2.0.2 changed the behavior around open-ended dependencies...

austb
austb previously approved these changes Aug 1, 2017
View reviewed changes
Copy link
Contributor

@austb austb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was typing the commit message when you pushed this, but you won fair and square.

@austb austb dismissed their stale review August 1, 2017 17:47

No one ran all the test

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 89.708% when pulling dedb4bb on scotje:fixup_metadata_check into cdbbe6b on puppetlabs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 89.708% when pulling 3a5afa6 on scotje:fixup_metadata_check into cdbbe6b on puppetlabs:master.

@scotje scotje merged commit 7e7fe89 into puppetlabs:master Aug 1, 2017
@scotje scotje deleted the fixup_metadata_check branch August 1, 2017 18:13
@scotje scotje added the bug label Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austb austb austb approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scotje @coveralls @austb