(SDK-331) Use vendored Gemfile.lock when available and needed #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotje
force-pushed
the
331_vendored_gemfile_lock
branch
from
6738f16
to
708209e
Compare
scotje
force-pushed
the
331_vendored_gemfile_lock
branch
from
708209e
to
7e9b049
Compare
rodjek
reviewed
Aug 2, 2017
spec/unit/pdk/util/bundler_spec.rb
Outdated
| allow(File).to receive(:exist?).with('/package/cachedir/Gemfile.lock').and_return(true) | ||
|
|
||
| expect(logger).to receive(:debug).with(%r{using vendored gemfile\.lock}i) | ||
| expect(FileUtils).to receive(:cp) |
There was a problem hiding this comment.
Should test the arguments to FileUtils.cp here, for completeness.
scotje
force-pushed
the
331_vendored_gemfile_lock
branch
from
7e9b049
to
81ed6b9
Compare
bmjen
approved these changes
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.