Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-397) Log output of bundler commands at appropriate levels #243

Merged
merged 1 commit into from
Aug 11, 2017

Conversation

scotje
Copy link
Contributor

@scotje scotje commented Aug 11, 2017

Output of bundle check should go to DEBUG but non-zero exit status for the rest of the bundler commands represent fatal errors.

@scotje scotje added the feature label Aug 11, 2017
@coveralls
Copy link

coveralls commented Aug 11, 2017

Coverage Status

Coverage decreased (-0.02%) to 93.677% when pulling 7cf2d71 on scotje:397_hide_bundle_check_output into 29937f8 on puppetlabs:master.

@scotje
Copy link
Contributor Author

scotje commented Aug 11, 2017

Coveralls failure is because there was a net decrease of 5 lines in a covered file, coverage of that file is still 100% of relevant lines...

@bmjen bmjen merged commit 53436e1 into puppetlabs:master Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants