(maint) Allow bundler to install gems in parallel #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set -j4 (4 jobs) when PDK calls bundle install to allow bundler to install gems in parallel.
james-stocks
force-pushed
the
bundle_options
branch
from
ccfc750
to
2833467
Compare
|
On my 2 core laptop; setting -j2 makes no difference to not setting it at all (about 37 seconds average in both cases). On travis and appveyor, -j2 or -j4 make no noticeable difference - both systems are subject to a lot of variance, so if seconds were being shaved off the time; it would be lost in the variance. |
austb
approved these changes
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set jobs=2 when PDK calls bundle install to allow bundler to install gems in parallel.
It could be set higher than 2 but that might require testing to check it has no issues and even saves any time on workstations with less processing resource.