(SDK-336) Add operating system question to the new module interview #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
approved these changes
Sep 6, 2017
There was a problem hiding this comment.
Nice. I tried it out on Linux, and it worked fine!
I'll merge as soon as the rubocop fixes have passed CI.
When looking at the output, I was thinking about sorting the operatingsystem_support section by OS name, but a) the to_json method only calls to the library, making that harder than it looked, and b) having it like this keeps the siblings together in the list, which is a bonus.
Without this pressing ^C at the final prompt in the interview would cause an ugly stack trace: ``` About to generate this module; continue? (Y/n) /home/david/gems/ruby/2.3.0/gems/tty-prompt-0.13.1/lib/tty/prompt/reader.rb:336:in `handle_interrupt': TTY::Prompt::Reader::InputInterrupt (TTY::Prompt::Reader::InputInterrupt) from /home/david/gems/ruby/2.3.0/gems/tty-prompt-0.13.1/lib/tty/prompt/reader.rb:137:in `get_codes' from /home/david/gems/ruby/2.3.0/gems/tty-prompt-0.13.1/lib/tty/prompt/reader.rb:174:in `block in read_line' from /home/david/gems/ruby/2.3.0/gems/tty-prompt-0.13.1/lib/tty/prompt/reader.rb:97:in `unbufferred' from /home/david/gems/ruby/2.3.0/gems/tty-prompt-0.13.1/lib/tty/prompt/reader.rb:174:in `read_line' from /home/david/gems/ruby/2.3.0/gems/tty-prompt-0.13.1/lib/tty/prompt/question.rb:158:in `read_input' from /home/david/gems/ruby/2.3.0/gems/tty-prompt-0.13.1/lib/tty/prompt/question.rb:147:in `process_input' from /home/david/gems/ruby/2.3.0/gems/tty-prompt-0.13.1/lib/tty/prompt/question.rb:112:in `render' from /home/david/gems/ruby/2.3.0/gems/tty-prompt-0.13.1/lib/tty/prompt/confirm_question.rb:65:in `call' from /home/david/gems/ruby/2.3.0/gems/tty-prompt-0.13.1/lib/tty/prompt.rb:314:in `yes?' from /home/david/git/pdk/lib/pdk/generators/module.rb:310:in `module_interview' ```
|
Appveyor needed a rebuild to become green, after failing to git clone some dependencies. |
rodjek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP because I need to test this out on windows