(maint) Debug output GEM_HOME and GEM_PATH before executing module commands #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-stocks
commented
Aug 24, 2017
lib/pdk/cli/exec.rb
Outdated
| @@ -217,6 +217,9 @@ def run_process_in_clean_env! | |||
| def run_process! | |||
| command_string = argv.join(' ') | |||
| PDK.logger.debug(_("Executing '%{command}'") % { command: command_string }) | |||
| if context == :module | |||
| PDK.logger.debug(_("GEM_HOME is '%{gem_home}' and GEM_PATH is '%{gem_path}'") % { gem_home: @process.environment['GEM_HOME'], gem_path: @process.environment['GEM_PATH'] }) | |||
There was a problem hiding this comment.
Hmm this should perhaps specify that these are the environment values for the command process
…mmands To aid troubleshooting in cases of ruby environment doubts.
james-stocks
force-pushed
the
log_gem_env
branch
from
378512d
to
6e2cb5a
Compare
DavidS
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To aid troubleshooting in cases of ruby environment doubts.