(PDK-420) Ensure Puppet and Puppet::Util modules are defined #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodjek
force-pushed
the
pdk-420
branch
3 times, most recently
from
a884de5
to
1b73787
Compare
rodjek
force-pushed
the
pdk-420
branch
2 times, most recently
from
ee4feb9
to
6a3543d
Compare
rodjek
force-pushed
the
pdk-420
branch
8 times, most recently
from
76f2b33
to
a2b4e1a
Compare
rodjek
force-pushed
the
pdk-420
branch
2 times, most recently
from
df48c82
to
7fe53f7
Compare
Puppet 5 changed the format of the module definition in Puppet::Util::Windows from the expanded to condensed format. The downside of this change is that it means that the requires are now order dependent, as the condensed format does not define the parent objects if not already defined. This change abstracts our require of `puppet/util/windows`, allowing us to define the `Puppet` and `Puppet::Util` modules before requiring `puppet/util/windows`, fixing the exception caused when `pdk` and `puppet` exist in the same gemfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet 5 changed the format of the module definition in Puppet::Util::Windows
from the expanded to condensed format. The downside of this change is that it
means that the requires are now order dependent, as the condensed format does
not define the parent objects if not already defined.
This change abstracts our require of
puppet/util/windows, allowing us todefine the
PuppetandPuppet::Utilmodules before requiringpuppet/util/windows, fixing the exception caused whenpdkandpuppetexist in the same gemfile.