(PDK-461) Make Version.git_ref more forgiving #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
force-pushed
the
pdk-461-better-version
branch
from
9210a1c
to
95b6d0c
Compare
rodjek
reviewed
Sep 5, 2017
lib/pdk/util/version.rb
Outdated
|
|
||
| ref_result[:stdout].strip if ref_result[:exit_code].zero? | ||
| return '' unless File.directory?(source_git_dir) |
There was a problem hiding this comment.
Can we return nil here instead of an empty string?
When there is no target `.git` directory, no need to call git at all. Also adds more tests to cover everything.
DavidS
force-pushed
the
pdk-461-better-version
branch
from
95b6d0c
to
34ab82e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no target
.gitdirectory, no need to call git at all.Also adds more tests to cover everything.