Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-459) Improve error message when the generation target exists #285

Merged
merged 1 commit into from
Sep 5, 2017
Merged

(PDK-459) Improve error message when the generation target exists #285

merged 1 commit into from
Sep 5, 2017

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Sep 5, 2017 

foo$ ~/git/pdk/bin/pdk new def bar
pdk (FATAL): Unable to generate defined_type; '/home/david/git/pdk/foo/manifests/bar.pp' already exists.
foo$ ~/git/pdk/bin/pdk new class bar
pdk (FATAL): Unable to generate class; '/home/david/git/pdk/foo/manifests/bar.pp' already exists.
foo$

@DavidS
(PDK-459) Improve error message when the generation target exists
d4f402a 
```
foo$ ~/git/pdk/bin/pdk new def bar
pdk (FATAL): Unable to generate defined_type; '/home/david/git/pdk/foo/manifests/bar.pp' already exists.
foo$ ~/git/pdk/bin/pdk new class bar
pdk (FATAL): Unable to generate class; '/home/david/git/pdk/foo/manifests/bar.pp' already exists.
foo$
```
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.857% when pulling d4f402a on DavidS:fixup into 1d6e2bc on puppetlabs:master.

@rodjek rodjek merged commit 32eee98 into puppetlabs:master Sep 5, 2017
@DavidS DavidS deleted the fixup branch September 5, 2017 16:57
@DavidS DavidS added feature and removed feature labels Sep 5, 2017
@bmjen bmjen added the feature label Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodjek rodjek rodjek approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DavidS @coveralls @rodjek @bmjen