Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-555) Handle windows style (backslash separated) paths when validating #306

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Oct 3, 2017

Dir.glob doesn't support backslash separated paths due to backslashes being used to escape characters, so we convert the ALT_SEPARATORs to SEPARATORs in user supplied paths before using them.

@puppetlabs puppetlabs deleted a comment from coveralls Oct 3, 2017
@rodjek rodjek force-pushed the pdk-555 branch 3 times, most recently from c0d9fe9 to 621e3f0 Compare October 3, 2017 05:32
@puppetlabs puppetlabs deleted a comment from coveralls Oct 3, 2017
@puppetlabs puppetlabs deleted a comment from coveralls Oct 3, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 93.375% when pulling 0865ee0 on rodjek:pdk-555 into e968f2d on puppetlabs:master.

@DavidS DavidS merged commit 048c02f into puppetlabs:master Oct 3, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 93.375% when pulling c5ff9b4 on rodjek:pdk-555 into e968f2d on puppetlabs:master.

@rodjek rodjek deleted the pdk-555 branch October 3, 2017 16:48
@DavidS DavidS added the bug label Oct 4, 2017
@DavidS DavidS changed the title (PDK-555) Handle windows style (backslash separated) paths (PDK-555) Handle windows style (backslash separated) paths when validating Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants