Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-408) Explain PowerShell escaping for -- on bundle #309

Merged
merged 1 commit into from
Oct 5, 2017

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Oct 4, 2017

PowerShell evaluates '--' itself and doesn't pass it on to the pdk
function. The backtick stops PowerShell from further argument parsing
and saves the double dash from being gobbled up.

To make it easier to discover by windows users, this also changes the
usage, when run on windows.

@DavidS DavidS added the bug label Oct 4, 2017
@DavidS DavidS requested a review from Sharpie October 4, 2017 13:19
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 93.326% when pulling 592c426 on DavidS:pdk-408-bundle-usage into 048c02f on puppetlabs:master.

PowerShell evaluates '--' itself and doesn't pass it on to the pdk
function. The backtick stops PowerShell from further argument parsing
and saves the double dash from being gobbled up.

To make it easier to discover by windows users, this also changes the
usage, when run on windows.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 93.326% when pulling 1aa842d on DavidS:pdk-408-bundle-usage into 048c02f on puppetlabs:master.

Copy link
Member

@Sharpie Sharpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for looking into this 👍

@rodjek rodjek merged commit 3acb9e9 into puppetlabs:master Oct 5, 2017
@DavidS DavidS deleted the pdk-408-bundle-usage branch January 17, 2018 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants