Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-628) Addition of module_name question to interview #327

Merged
merged 3 commits into from
Nov 8, 2017

Conversation

HelenCampbell
Copy link
Contributor

Adds the module_name question to the interview without disturbing generate functionality.

Also includes two cleanups:

  • Renaming 'name' to 'forge_username' for clarity.
  • Moves all tests formally under spec/unit/cli to spec/unit/pdk/cli.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 92.3% when pulling 407f9fa on HelenCampbell:questionname into 9de9532 on puppetlabs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 92.3% when pulling 4118b42 on HelenCampbell:questionname into 9de9532 on puppetlabs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 92.3% when pulling a666b20 on HelenCampbell:questionname into 9de9532 on puppetlabs:master.

@bmjen bmjen added the feature label Oct 23, 2017
Copy link
Contributor

@DavidS DavidS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't implement PDK-628:

david@davids:~/git/pdk$ git describe --all --long
heads/questionname-0-ga666b20
david@davids:~/git/pdk$ ./bin/pdk new module
NAME
    module - Create a new module named <module_name> using given options
[...]

@DavidS
Copy link
Contributor

DavidS commented Oct 30, 2017

(although, having said that, we might want to merge this as first step, and come back later to finish implementation)

@rodjek
Copy link
Contributor

rodjek commented Nov 8, 2017

I think it makes sense to split pdk-628 into two PRs (this one to modify the interview in order to accommodate the convert functionality and a follow up one that modifies the CLI functionality)

Helen Campbell added 3 commits November 8, 2017 11:17
This enables the re-use of the modules interview with pdk convert without disturbing generate new module workflow.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 92.3% when pulling fc0e834 on HelenCampbell:questionname into ad600d6 on puppetlabs:master.

@DavidS DavidS merged commit 34d3e63 into puppetlabs:master Nov 8, 2017
@DavidS
Copy link
Contributor

DavidS commented Nov 8, 2017

I've successfully ran the acceptance:local tests on my machine to stand in until travis fixes their bundler issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants