Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-671) Makes module_name optional for pdk new module. #344

Merged
merged 1 commit into from
Nov 9, 2017
Merged

(PDK-671) Makes module_name optional for pdk new module. #344

merged 1 commit into from
Nov 9, 2017

Conversation

bmjen
Copy link
Contributor

@bmjen bmjen commented Nov 9, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 92.436% when pulling f67d6dd on bmjen:pdk-671 into acc5897 on puppetlabs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 92.436% when pulling ad33f0a on bmjen:pdk-671 into acc5897 on puppetlabs:master.

HelenCampbell
HelenCampbell approved these changes Nov 9, 2017
View reviewed changes
Copy link
Contributor

@HelenCampbell HelenCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bmjen bmjen merged commit 64fbbc3 into puppetlabs:master Nov 9, 2017
@bmjen bmjen deleted the pdk-671 branch November 9, 2017 22:02
@bmjen bmjen added the feature label Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HelenCampbell HelenCampbell HelenCampbell approved these changes

@rodjek rodjek Awaiting requested review from rodjek

@DavidS DavidS Awaiting requested review from DavidS

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmjen @coveralls @HelenCampbell