(PDK-715) Use correct module template branch/ref #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmjen
changed the title
scotje
reviewed
Dec 4, 2017
lib/pdk/util.rb
Outdated
| def development_mode? | ||
| PDK::VERSION.end_with? 'pre' | ||
| end | ||
| module_function :development_mode? |
There was a problem hiding this comment.
Should this maybe test if the code is part of a git checkout or something instead?
There was a problem hiding this comment.
It could, but that could complicate matters if we (or others) attempt to run a tag from source for a repro or something? I think ultimately, the simplicity of just checking whether we're on an "official" version or a dev/preview version is more explicit. I could go either way.
bmjen
force-pushed
the
fix-git
branch
2 times, most recently
from
19a2488
to
18175b1
Compare
|
This seems like it breaks anyone using a custom template repo that doesn't have the hard coded version/ref. Does just adding and plumbing through a |
For gem installs, we need to make sure they use a compatible module-template version, similar to what we do for package installs in our build process. For development, we still want to use the default git branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For gem installs, we need to make sure they use a compatible
module-template version, similar to what we do for package installs
in our build process. For development, we still want to use the
default git branch.