(PDK-728) Add default_template_ref handler. #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotje
approved these changes
Dec 5, 2017
lib/pdk/module/templatedir.rb
Outdated
| else # TODO: Once we decide on a branching strategy for the pdk-module-template, this needs to be updated. | ||
| PDK::Util::Git.git('clone', path_or_url, '--branch', 'convert', temp_dir) | ||
| end | ||
| clone_result = PDK::Util::Git.git('clone', path_or_url, '--branch', PDK::Util.default_template_ref, temp_dir) |
There was a problem hiding this comment.
We should consider making this a clone and then reset --hard to the desired ref. clone --branch only supports branches and tags. This is probably fine for now though.
There was a problem hiding this comment.
Probably a good idea. Going to hold off on merging this and potentially breaking the vanagon build.
bmjen
changed the title
bmjen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.