Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK 719) Directory layout and metadata fixes during convert #383

Merged
merged 2 commits into from
Dec 8, 2017

Conversation

HelenCampbell
Copy link
Contributor

@HelenCampbell HelenCampbell commented Dec 8, 2017

Closes #379

Falls back to checking for `manifests/`, `lib/`, `tasks/`, `functions/`, and
`types/` if the module does not contain a `metadata.json`. This logic is not
enabled by default as we should only need to do this during convert (after
that, a `metadata.json` file should be present).

`templates/`, `files/`, `spec/` are not checked for, as it's unlikely they'll
exist without one of the other directories being present.
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.4%) to 90.68% when pulling b16b766 on HelenCampbell:PDK-719 into c182aa6 on puppetlabs:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.4%) to 90.68% when pulling d056194 on HelenCampbell:PDK-719 into c182aa6 on puppetlabs:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 93.01% when pulling 10d4d08 on HelenCampbell:PDK-719 into c182aa6 on puppetlabs:master.

@bmjen bmjen merged commit 2c3b9f3 into puppetlabs:master Dec 8, 2017
@chelnak chelnak added the bug label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants