Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-643) Disable non-exec validator spinners when noninteractive #385

Merged
merged 1 commit into from
Dec 12, 2017
Merged

(PDK-643) Disable non-exec validator spinners when noninteractive #385

merged 1 commit into from
Dec 12, 2017

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Dec 10, 2017

The spinners in PDK::Validate::MetadataSyntax and PDK::Validate::TaskMetadataLint were missed in the first pass as they don't follow the usual pattern of executing an external command.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 93.004% when pulling 90ae570 on rodjek:pdk-643-2 into 6072d10 on puppetlabs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 93.004% when pulling ec76e39 on rodjek:pdk-643-2 into 6072d10 on puppetlabs:master.

@bmjen bmjen merged commit 9140ac9 into puppetlabs:master Dec 12, 2017
@rodjek rodjek deleted the pdk-643-2 branch December 13, 2017 08:23
@bmjen bmjen added the bug label Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmjen bmjen bmjen approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodjek @coveralls @bmjen