(PDK-736) Improve handling of old template-url and template-ref #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if the user had the old puppetlabs/pdk-module-template URL saved in their answers.json, PDK would still try to use the old repo but attempt to reset to the `1.3.0` tag which doesn't exist in the old repo. This commit starts treating a value matching the old repo URL the same as if there is no template URL specified so that it uses the new template URL instead. Furthermore, if the user had a real custom template repo, we were still attempting to reset to the `1.3.0` tag which probably won't exist in their custom repo. After this commit, pdk will only try to reset to the pinned tag when using the official template repo (or packaged repo).
|
Tested this with "template-url": "https://github.com/puppetlabs/pdk-module-template" in the answers file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the user had the old puppetlabs/pdk-module-template URL
saved in their answers.json, PDK would still try to use the old repo but
attempt to reset to the
1.3.0tag which doesn't exist in the old repo.This commit starts treating a value matching the old repo URL the same
as if there is no template URL specified so that it uses the new
template URL instead.
Furthermore, if the user had a real custom template repo, we were still
attempting to reset to the
1.3.0tag which probably won't exist intheir custom repo. After this commit, pdk will only try to reset to the
pinned tag when using the official template repo (or packaged repo).