(PDK-575) Run puppet parser validate with an dummy empty puppet.conf #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotje
reviewed
Jan 12, 2018
| @@ -36,7 +40,7 @@ | |||
| let(:options) { { auto_correct: true } } | |||
|
|
|||
| it 'has no effect' do | |||
| expect(command_args).to eq(%w[parser validate].concat(targets)) | |||
| expect(command_args).to eq(%w[parser validate --config /dev/null].concat(targets)) | |||
There was a problem hiding this comment.
Is the purpose of this existing auto_correct test assertion to make sure that some option is not being added? If so should we maybe just assert that the option is absent rather than having to update this test every time the invocation changes?
Also should we have a new test that explicitly checks for the --config param?
bmjen
approved these changes
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent any user or system level puppet.conf settings from interfering with the behaviour of the PDK, pass
/dev/nullorNUL(depending on the platform) as the puppet.conf when runningpuppet parser validate.