Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-550) Removes unrequired questions from module interview #410

Merged
merged 4 commits into from
Jan 24, 2018
Merged

(PDK-550) Removes unrequired questions from module interview #410

merged 4 commits into from
Jan 24, 2018

Conversation

bmjen
Copy link
Contributor

@bmjen bmjen commented Jan 19, 2018

PR includes:

  • Removes unrequired questions from module interview
  • Adds a --full-interview option to new module to ask all of the questions from the module interview.
  • changes the warning about forge username sanitization to a debug msg.

@coveralls
Copy link

coveralls commented Jan 19, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 93.241% when pulling 5e2c202 on bmjen:pdk-550 into 2b55f1a on puppetlabs:master.

@bmjen bmjen changed the title (PDK-550) Removes unrequired questions from module interview {WIP}(PDK-550) Removes unrequired questions from module interview Jan 22, 2018
@bmjen bmjen changed the title {WIP}(PDK-550) Removes unrequired questions from module interview (PDK-550) Removes unrequired questions from module interview Jan 22, 2018
@bmjen bmjen requested review from rodjek and scotje January 22, 2018 23:58
rodjek
rodjek approved these changes Jan 23, 2018
View reviewed changes
Copy link
Contributor

@rodjek rodjek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍. Should we add the --full-interview flag to pdk convert as well, for consistency?

@bmjen
(PDK-550) Add --full-interview flag to convert command
5e2c202 
Also adds CLI error handling of conflicting options and unit tests.
@bmjen
Copy link
Contributor Author

bmjen commented Jan 23, 2018

@rodjek Updated with --full-interview option to convert. Quick re-review?

@bmjen bmjen merged commit b939b8e into puppetlabs:master Jan 24, 2018
@bmjen bmjen deleted the pdk-550 branch January 24, 2018 17:10
@bmjen bmjen added the feature label Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodjek rodjek rodjek approved these changes

@scotje scotje Awaiting requested review from scotje

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmjen @coveralls @rodjek