Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-799) Adds validations and checks to pdk build workflow #416

Merged
merged 4 commits into from
Feb 6, 2018
Merged

(PDK-799) Adds validations and checks to pdk build workflow #416

merged 4 commits into from
Feb 6, 2018

Conversation

bmjen
Copy link
Contributor

@bmjen bmjen commented Feb 6, 2018

No description provided.

@bmjen bmjen requested a review from rodjek February 6, 2018 01:11
@bmjen bmjen force-pushed the pdk-799 branch 2 times, most recently from 6622985 to 88bae2c Compare February 6, 2018 02:39
rodjek and others added 2 commits February 5, 2018 19:48
@coveralls
Copy link

coveralls commented Feb 6, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.4%) to 91.007% when pulling 5b76377 on bmjen:pdk-799 into dd74bb2 on puppetlabs:master.

rodjek
rodjek approved these changes Feb 6, 2018
View reviewed changes
Copy link
Contributor

@rodjek rodjek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending a successful build ;)

@bmjen bmjen merged commit f6e5d90 into puppetlabs:master Feb 6, 2018
@bmjen bmjen deleted the pdk-799 branch March 11, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodjek rodjek rodjek approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmjen @coveralls @rodjek @chelnak