Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validation regex and error message for module name question #430

Merged
merged 1 commit into from
Feb 16, 2018
Merged

Update validation regex and error message for module name question #430

merged 1 commit into from
Feb 16, 2018

Conversation

ardrigh
Copy link
Contributor

@ardrigh ardrigh commented Feb 16, 2018

PDK does not correctly validate module names if a module name is not supplied to pdk new module.

The user question prompts for a module name but fails to pass underscores as valid.

  • pdk new module test_name will pass
  • pdk new module will fail on test_name given as the module name.

This update uses the regex referred to in the docs for validating module names.

I have included a similar error message to the options validation line, while referring to "numbers" as the docs do.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.071% when pulling d471a2c on ardrigh:module_validation into 85c33fa on puppetlabs:master.

@bmjen
Copy link
Contributor

bmjen commented Feb 16, 2018

Great find @ardrigh and thanks for the contribution!

@bmjen bmjen merged commit 4106b3a into puppetlabs:master Feb 16, 2018
@bmjen bmjen added the bug label Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants