(maint) Allow pdk bundle to work without --
#466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By upgrading to the new version of CRI, the `skip_option_parsing` call can be used to avoid the previous confusion of bundle vs pdk options.
|
This is a prerequisite for #331 |
bmjen
suggested changes
Apr 12, 2018
| @@ -22,7 +22,7 @@ Gem::Specification.new do |spec| | |||
| spec.required_ruby_version = '>= 2.1.9' | |||
|
|
|||
| spec.add_runtime_dependency 'bundler', '~> 1.15' | |||
| spec.add_runtime_dependency 'cri', '~> 2.9.1' | |||
| spec.add_runtime_dependency 'cri', '~> 2.10.1' | |||
There was a problem hiding this comment.
Is this update required for the bundle command changes? I'd prefer if this was taken out and a new ticket created to update CRI, so we can update the vanagon component at the same time.
bmjen
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By upgrading to the new version of CRI, the
skip_option_parsingcall can be used to avoid the previous confusion of bundle vs pdk
options.