Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) Allow module name to contain underscores when verifying #491

Merged
merged 1 commit into from
Apr 27, 2018
Merged

(maint) Allow module name to contain underscores when verifying #491

merged 1 commit into from
Apr 27, 2018

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Apr 26, 2018 •
edited
Loading

This change prevents the metadata interview from re-asking for the module name if the module name contains underscores.

@rodjek rodjek added the blocked label Apr 26, 2018
@coveralls
Copy link

coveralls commented Apr 26, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 92.723% when pulling 66e8879 on rodjek:nwalker_issue into acf1489 on puppetlabs:master.

@rodjek rodjek removed the blocked label Apr 26, 2018
@bmjen bmjen merged commit 9ab1128 into puppetlabs:master Apr 27, 2018
@rodjek rodjek deleted the nwalker_issue branch April 27, 2018 00:40
@bmjen bmjen added the bug label Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmjen bmjen bmjen approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodjek @coveralls @bmjen