Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-985) Split validation targets into chunks of 1000 #509

Merged
merged 2 commits into from
Jun 14, 2018

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented May 15, 2018

In order to work around argument list length limits.

@coveralls
Copy link

coveralls commented May 15, 2018

Coverage Status

Coverage increased (+0.04%) to 92.895% when pulling b71286b on rodjek:pdk-985 into 455f488 on puppetlabs:master.

@scotje
Copy link
Contributor

scotje commented May 16, 2018

@rodjek is this still WIP?

@rodjek rodjek force-pushed the pdk-985 branch 3 times, most recently from f4c3d16 to 0f51753 Compare June 7, 2018 06:04
@rodjek rodjek changed the title [WIP] (PDK-985) Split validation targets into chunks of 1000 (PDK-985) Split validation targets into chunks of 1000 Jun 7, 2018
@rodjek
Copy link
Contributor Author

rodjek commented Jun 7, 2018

@scotje Not any more :)

@rodjek rodjek requested review from scotje and bmjen June 7, 2018 07:23
@scotje
Copy link
Contributor

scotje commented Jun 11, 2018

There seem to be some issues with how the new code interacts with the multispinner:

$ lpdk validate --parallel
pdk (INFO): Running all available validators...
pdk (INFO): Using Ruby 2.4.4
pdk (INFO): Using Puppet 5.5.1
┌ [✔] Validating module using 3 threads        ┌
└──[✔] Checking metadata syntax (metadata.json ┌ ─ks/*.json).
└──[/] Checking module metadata style (metadata├──on).
└──[✔] Checking module metadata style (metadata├──on).
└──[✔] Checking task metadata style (tasks/*.json).
[✔] Checking Puppet manifest syntax (**/**.pp).
[✔] Checking Puppet manifest style (**/*.pp).
convention: rubocop: spec/unit/puppet/provider/testprovider/testprovider_spec.rb:4:1: Style/Documentation: Missing top-level module documentation comment.

vs master:

pdk (INFO): Running all available validators...
pdk (INFO): Using Ruby 2.4.4
pdk (INFO): Using Puppet 5.5.1
┌ [✖] Validating module using 3 threads
├──[✖] Checking Ruby code style (**/**.rb).
├──[✔] Checking metadata syntax (metadata.json tasks/*.json).
├──[✔] Checking Puppet manifest syntax (**/**.pp).
├──[✔] Checking module metadata style (metadata.json).
├──[✔] Checking task metadata style (tasks/*.json).
└──[✔] Checking Puppet manifest style (**/*.pp).
convention: rubocop: spec/unit/puppet/provider/testprovider/testprovider_spec.rb:4:1: Style/Documentation: Missing top-level module documentation comment.

I'm going to see if I can figure out what is going on.

@bmjen
Copy link
Contributor

bmjen commented Jun 14, 2018

https://tickets.puppetlabs.com/browse/PDK-1032 Was created to track and fix the multi-spinner display.

@bmjen bmjen merged commit a5c5c15 into puppetlabs:master Jun 14, 2018
@rodjek rodjek deleted the pdk-985 branch June 17, 2018 06:43
@bmjen bmjen added the bug label Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants