(PDK-949) Add a default knockout_prefix for options #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the config_defaults.yml and .sync.yml were deep merged without any options. This commit adds in the ability to use a knockout_prefix of '---' for any config_defaults.yml options. The main use case for this is to remove items from the `config_defaults.yml` in the template.
scotje
approved these changes
Jun 1, 2018
|
Thanks for your contribution @jarretlavallee ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR the config_defaults.yml and .sync.yml were deep
merged without any options. This commit adds in the ability to use a
knockout_prefix of '---' for any config_defaults.yml options.
The main use case for this is to remove items from the
config_defaults.ymlin the template.I am happy to change the default knockout_prefix from '---' to anything else. Let me know if you would prefer a different one.