(PDK-1061) Ensure rake binstub when building module #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before building a module package, we first call `PDK::Test::Unit.tear_down` to make sure that there are no artifacts left over from possible test runs. This method depends on the `rake` binstub being present which is ensured when running `pdk test unit`, however when the user is running `pdk build` on a clean clone of a module this binstub is not present and the build fails.
scotje
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before building a module package, we first call
PDK::Test::Unit.tear_downto make sure that there are no artifactsleft over from possible test runs. This method depends on the
rakebinstub being present which is ensured when running
pdk test unit,however when the user is running
pdk buildon a clean clone ofa module this binstub is not present and the build fails.