(PDK-1067) Ensure rspec-core binstubs are created for pdk test unit
#546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the way the parallel_tests gem invokes rspec, we need to make sure we have generated a binstub within the module for rspec. Otherwise when a user invokes `pdk test unit --parallel`, parallel_tests will attempt to invoke rspec outside of the PDK-managed Ruby environment.
The package acceptance test suite for multiple puppet version support was calling `pdk bundle update` which was causing non-packaged gems to be downloaded into the user cachedir by PDK. This caused later test suites to resolve onto those non-packaged gems which would cause unexpected diffs in the module's Gemfile.lock. This commit updates the multi-puppet test suite to use `pdk bundle update --local` and also ensures that the PDK user cachedir is cleaned between each test.
bmjen
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the way the parallel_tests gem invokes rspec, we need to make
sure we have generated a binstub within the module for rspec. Otherwise
when a user invokes
pdk test unit --parallel, parallel_tests willattempt to invoke rspec outside of the PDK-managed Ruby environment.