Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-1073) Fix gem bin paths for CLI::Exec managed subprocesses #551

Merged
merged 1 commit into from
Jul 16, 2018
Merged

(PDK-1073) Fix gem bin paths for CLI::Exec managed subprocesses #551

merged 1 commit into from
Jul 16, 2018

Conversation

scotje
Copy link
Contributor

@scotje scotje commented Jul 16, 2018

Before we were appending 'bin' to the end of GEM_PATH but that did not
consider the case where GEM_PATH contains multiple paths.

@scotje
(PDK-1073) Fix gem bin paths for CLI::Exec managed subprocesses
8c3ffea 
Before we were appending 'bin' to the end of GEM_PATH but that did not
consider the case where GEM_PATH contains multiple paths.
@scotje scotje requested a review from rodjek July 16, 2018 19:03
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 92.807% when pulling 8c3ffea on scotje:1073_pdk_bundle_path into bc3667e on puppetlabs:master.

@rodjek rodjek merged commit 0fd4dde into puppetlabs:master Jul 16, 2018
@scotje scotje deleted the 1073_pdk_bundle_path branch July 16, 2018 23:34
@chelnak chelnak added the bug label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodjek rodjek Awaiting requested review from rodjek

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scotje @coveralls @rodjek @chelnak