(PDK-1099) Merge Puppet::Util::Windows into PDK namespace #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodjek
force-pushed
the
pdk-1099
branch
2 times, most recently
from
546e101
to
3b04614
Compare
rodjek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls the minimum amount of
Puppet::Util::Windowsinto thePDKnamespace to meet our needs. I've maintained the existing file structure so that if we need to add another FFI method in the future it can be done easily.The main benefit of this change is that it will allow the PDK and Puppet gems to be colocatable without any potential conflicts due to the vendored code.