(PDK-1056) Adds support for Ruby 2.5.1 in packaged PDK version #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodjek
suggested changes
Aug 30, 2018
lib/pdk/util/ruby_version.rb
Outdated
| @@ -45,10 +45,17 @@ def scan_for_packaged_rubies | |||
| end | |||
|
|
|||
| def default_ruby_version | |||
| # For now, the packaged versions will not be using default of 2.4.4. | |||
| '2.4.4' if PDK::Util.package_install? | |||
There was a problem hiding this comment.
I think you meant to return '2.4.4' here
lib/pdk/util/ruby_version.rb
Outdated
| @@ -45,10 +45,17 @@ def scan_for_packaged_rubies | |||
| end | |||
|
|
|||
| def default_ruby_version | |||
| # For now, the packaged versions will not be using default of 2.4.4. | |||
| '2.4.4' if PDK::Util.package_install? | |||
|
|
|||
| # TODO: may not be a safe assumption that highest available version should be default | |||
| versions.keys.sort { |a, b| Gem::Version.new(b) <=> Gem::Version.new(a) }.first | |||
There was a problem hiding this comment.
Should change this line to just call latest_ruby_version now to get rid of the duplicated code
bmjen
force-pushed
the
r2.5.1
branch
2 times, most recently
from
9fc0623
to
854c10f
Compare
scotje
approved these changes
Aug 30, 2018
bmjen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change here to ensure that the packaged version of PDK will default to 2.4.4, but also adds a helper function to identify the newest version of Ruby in the package.