(PDK-1172) Call PDK::Util::Bundler.ensure_bundle! after module creation #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotje
approved these changes
Nov 1, 2018
scotje
reviewed
Nov 1, 2018
| @@ -84,6 +84,8 @@ def self.invoke(opts = {}) | |||
|
|
|||
| begin | |||
| if FileUtils.mv(temp_target_dir, target_dir) | |||
| Dir.chdir(target_dir) { PDK::Util::Bundler.ensure_bundle! } | |||
There was a problem hiding this comment.
Do we want to do this regardless of whether or not it's a package install?
There was a problem hiding this comment.
I think so (unless anyone can think of a reason why not to), if for no other reason than keeping the behaviour consistent.
bmjen
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.