(PDK-1202) Pass TemplateDir object through to TemplateFile #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows templates to access configuration for other files if they really need to (for example, generating a `.puppet-lint.rc` from the checks being disabled in the Rakefile).
rodjek
added a commit
to rodjek/pdk-templates
that referenced
this pull request
Dec 4, 2018
Our current documented way of disabling puppet-lint checks is to use `.sync.yml` to specify a list of checks which is then used when generating the `lint` task in the `Rakefile`. Unfortunately, while this does take effect when running the tests in CI, it does not similarly change the behaviour of `pdk validate` which calls `puppet-lint` directly instead of using the rake task. This PR adds a new template for `.puppet-lint.rc` which gets built from the values specified for the `Rakefile` template. I have deliberately not added any new config keys specific to this template to reduce the chance of the puppet-lint configuration from getting out of sync again. This PR can not be merged until puppetlabs/pdk#605 is merged.
bmjen
approved these changes
Dec 10, 2018
rodjek
added a commit
to rodjek/pdk-templates
that referenced
this pull request
Dec 11, 2018
Our current documented way of disabling puppet-lint checks is to use `.sync.yml` to specify a list of checks which is then used when generating the `lint` task in the `Rakefile`. Unfortunately, while this does take effect when running the tests in CI, it does not similarly change the behaviour of `pdk validate` which calls `puppet-lint` directly instead of using the rake task. This PR adds a new template for `.puppet-lint.rc` which gets built from the values specified for the `Rakefile` template. I have deliberately not added any new config keys specific to this template to reduce the chance of the puppet-lint configuration from getting out of sync again. This PR can not be merged until puppetlabs/pdk#605 is merged.
rodjek
added a commit
to rodjek/pdk-templates
that referenced
this pull request
Dec 12, 2018
Our current documented way of disabling puppet-lint checks is to use `.sync.yml` to specify a list of checks which is then used when generating the `lint` task in the `Rakefile`. Unfortunately, while this does take effect when running the tests in CI, it does not similarly change the behaviour of `pdk validate` which calls `puppet-lint` directly instead of using the rake task. This PR adds a new template for `.puppet-lint.rc` which gets built from the values specified for the `Rakefile` template. I have deliberately not added any new config keys specific to this template to reduce the chance of the puppet-lint configuration from getting out of sync again. This PR can not be merged until puppetlabs/pdk#605 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows templates to access configuration for other files if they really need to (for example, generating a
.puppet-lint.rcfrom the checks being disabled in theRakefile). The config for another file can be accessed in the template using theconfig_formethod, e.g.