(PDK-1193) Saves packaged template-url in metadata as a keyword #639
Conversation
lib/pdk/util.rb
Outdated
| PACKAGED_TEMPLATE_KEYWORD = 'pdk-default'.freeze | ||
|
|
||
| PACKAGED_TEMPLATE_PATHS = { | ||
| 'windows' => 'file://C:/Program Files/Puppet Labs/DevelopmentKit/share/cache/pdk-templates.git', |
There was a problem hiding this comment.
Reminder to mention "non-default install locations on Windows need manual intervention by the user to fix this" in the Release Notes.
There was a problem hiding this comment.
We currently don't support changing the install location on Windows, so we know that anything in a version of PDK prior to the release of this fix will be at that static file path. Any modules converted or created after the introduction of this fix will appropriately show the static string.
rodjek
force-pushed
the
pdk-1193
branch
2 times, most recently
from
64df2b6
to
e875d87
Compare
| 'windows' => 'file:///C:/Program Files/Puppet Labs/DevelopmentKit/share/cache/pdk-templates.git', | ||
| 'macos' => 'file:///opt/puppetlabs/pdk/share/cache/pdk-templates.git', | ||
| 'linux' => 'file:///opt/puppetlabs/pdk/share/cache/pdk-templates.git', | ||
| }.freeze |
There was a problem hiding this comment.
Would it be possible to compute these from the relative path of the current file? I'm thinking about our hope to someday have the packages be relocatable and/or distributing a .zip package.
There was a problem hiding this comment.
Oh, I think this is what Bryan and David were already talking about, this is only for recognizing the package template paths before this change goes out since afterwards this will get converted to a keyword in the metadata. Does that sound correct?
If so, maybe we just rename this const to like LEGACY_PACKAGED_TEMPLATE_URLS or something similar?
Currently, for packaged installations the default templates template-url is saved in the metadata.json as the file path. This breaks when a module that is developed with PDK on Windows is moved to a Linux installation of PDK, since the Windows path doesn't exist. With this fix, the default packaged template path will be determined by PDK using the keyword 'pdk-default' in that same metadata.json field and the approriate platform specific template location will be used.
Currently, for packaged installations the default templates template-url
is saved in the metadata.json as the file path. This breaks when a
module that is developed with PDK on Windows is moved to a Linux installation
of PDK, since the Windows path doesn't exist. With this fix, the default
packaged template path will be determined by PDK using the keyword
'pdk-default' in that same metadata.json field and the approriate
platform specific template location will be used.
Requires #434