Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-1341) Hook up PDK analytics to Google Analytics #665

Merged
merged 1 commit into from
May 17, 2019
Merged

(PDK-1341) Hook up PDK analytics to Google Analytics #665

merged 1 commit into from
May 17, 2019

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented May 15, 2019

Submits a single screenview during pdk new module for now just for testing purposes. Will be fleshed out with real events in a follow up PR.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.343% when pulling 75789c7 on rodjek:pdk-1341 into 2f83c0f on puppetlabs:master.

scotje
scotje approved these changes May 16, 2019
View reviewed changes
Copy link
Contributor

@scotje scotje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I tested it out locally and saw my usage show up in the realtime google analytics report!

@rodjek rodjek merged commit 8635c97 into puppetlabs:master May 17, 2019
@rodjek rodjek deleted the pdk-1341 branch May 17, 2019 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotje scotje scotje approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rodjek @coveralls @scotje @chelnak