(PDK-1342) Submit PDK analytics events #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodjek
force-pushed
the
pdk-1342
branch
2 times, most recently
from
6a430ab
to
6ae5be8
Compare
scotje
reviewed
May 30, 2019
| end | ||
|
|
||
| context 'and provided no flags' do | ||
| after(:each) do | ||
| PDK::CLI.run(['convert']) | ||
| end |
There was a problem hiding this comment.
Would these be better as subject blocks?
There was a problem hiding this comment.
Not really, as the CLI run isn't the subject of the tests, it's just something that we have to do to trigger the logic being tested.
There was a problem hiding this comment.
I don't feel super strongly about the subject thing but I do think this happening in the after hook obfuscates things a bit.
scotje
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, I think this implements analytics submission for all the items that we're interested in according to our spec.
Common values that are submitted for every analytics event:
packageorgem)We submit a "screen view" for every successful CLI command invocation that records:
--puppet-versionand--pe-version)PDK_*environment variables and their values (if set)Invalid commands are submitted as a distinct analytics events with the arguments and option values redacted.
Whenever a template repo is used, we submit an event recording if the template is
defaultorcustom(n.b. we do not record the path to the template repo itself). Additionally, if the template repo being used is the default one, we submit events for each file rendered, recording if the file isunmanaged,deleted,customizedordefault(n.b. in the event of acustomizedfile, we do not record what was changed, only that it was changed via.sync.ymloverrides).Given the concerns of GDPR compliance you note that we're very carefully and strictly testing the analytics calls to ensure that no unexpected data is accidentally passed in.