(PDK-1365) Use dynamic ruby detection for default ruby instance #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
changed the title
glennsarti
force-pushed
the
pdk-1365-default-pup6
branch
2 times, most recently
from
aafa1ac
to
276e240
Compare
Previously the default version of ruby selected in packaged PDK instances was hardcoded to 2.4.5 which caused issues when updating ruby runtimes and did not reflect that the default should really by ruby 2.5 and Puppet 6. This commit modifies the default ruby detection to instead use the ruby environment for the latest Puppet Gem in the PDK package install. Non-pkged installs are not affected. This commit also memoizes the default value to slightly speed up default ruby selection.
glennsarti
force-pushed
the
pdk-1365-default-pup6
branch
from
276e240
to
2067abe
Compare
glennsarti
changed the title
rodjek
reviewed
Jun 11, 2019
rodjek
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the default version of ruby selected in packaged PDK instances was
hardcoded to 2.4.5 which caused issues when updating ruby runtimes and did not
reflect that the default should really by ruby 2.5 and Puppet 6. This commit
modifies the default ruby detection to instead use the ruby environment for the
latest Puppet Gem in the PDK package install. Non-pkged installs are not
affected.
This commit also memoizes the default value to slightly speed up default ruby
selection.